Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Run direct-minimal-versions tests on a weekly basis #78

Merged
merged 1 commit into from
May 7, 2023

Conversation

elasticdog
Copy link
Member

My understanding is that it's okay that we don't use these minimal versions directly in our normal/committed Cargo.lock file, because we may want to pick up more recent compatible versions that have addressed security issues or improved performance, etc. That said, we still want to periodically test the minimal versions to ensure that our own project still compiles and runs as expected. This will help to increase compatibility across the whole Rust ecosystem when there are shared dependencies and someone is using our library.

I've also abstracted out the CUE _testRust steps here, so they can be shared.

See:

My understanding is that it's okay that we don't use these minimal
versions directly in our normal/committed Cargo.lock file, because we
may want to pick up more recent compatible versions that have addressed
security issues or improved performance, etc. That said, we still
want to periodically test the minimal versions to ensure that our own
project still compiles and runs as expected. This will help to increase
compatibility across the whole Rust ecosystem when there are shared
dependencies and someone is using our library.

I've also abstracted out the CUE _testRust steps here, so they can be
shared.

See:
- rust-lang/cargo#11688
- https://doc.rust-lang.org/beta/cargo/reference/unstable.html#minimal-versions
- https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277
- https://twitter.com/jonhoo/status/1571290371124260865
- cue-lang/cue#860
@elasticdog elasticdog enabled auto-merge May 7, 2023 15:45
@elasticdog elasticdog added this pull request to the merge queue May 7, 2023
Merged via the queue into main with commit 4333cf5 May 7, 2023
@elasticdog elasticdog deleted the push-pyqmnrpppqup branch May 7, 2023 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant